• Home
    • View
    • Login
    This page
    • Normal
    • Export PDF
    • Export Word
    • Attachments
    • Page Information

    Loading...
  1. Dashboard
  2. OpenJFX
  3. Main
  4. Community
  5. Code Reviews

Page History

Versions Compared

Old Version 14

changes.mady.by.user Kevin Rushforth

Saved on Jul 24, 2014

compared with

New Version 15

changes.mady.by.user Steve Northover

Saved on Oct 01, 2014

  • Previous Change: Difference between versions 13 and 14
  • Next Change: Difference between versions 15 and 16
  • View Page History

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

In summary, during normal development, an owner can change code at will and does not require a pre-commit code review or even a JIRA to track trivial changes.  Of course, code cannot be committed during a code freeze or ramp down without authorization and almost all work should have a JIRA to track it.  Owners are seasoned developers who know that even a trivial change can cause significant hardship so they are naturally cautious and understand when a "trivial" change is not trivial and requires a JIRA and a code review.

IMPORTANT: Do not reformat code as part of a bug fix.  The makes more changes for code reviewers to track and review,  If you want to reformat a class, make a change set that has only formatting changes.  Do not reformat code that you do not own.

Technical Discussions and Code Reviews

...

Overview
Content Tools
ThemeBuilder

Terms of Use
• License: GPLv2
• Privacy • Trademarks • Contact Us

Powered by a free Atlassian Confluence Open Source Project License granted to https://www.atlassian.com/software/views/opensource-community-additional-license-offer. Evaluate Confluence today.

  • Kolekti ThemeBuilder Powered by Atlassian Confluence 8.5.21
  • Kolekti ThemeBuilder printed.by.atlassian.confluence
  • Report a bug
  • Atlassian News
Atlassian
Kolekti ThemeBuilder EngineAtlassian Confluence
{"serverDuration": 325, "requestCorrelationId": "3b3785ee9f308ed1"}