• Home
    • View
    • Login
    This page
    • Normal
    • Export PDF
    • Export Word
    • Attachments
    • Page Information

    Loading...
  1. Dashboard
  2. Lilliput
  3. Main
  4. JEP-450 Review Todo

Page History

Versions Compared

Old Version 15

changes.mady.by.user Thomas Stuefe

Saved on Sep 09, 2024

compared with

New Version 16

changes.mady.by.user Thomas Stuefe

Saved on Sep 10, 2024

  • Previous Change: Difference between versions 14 and 15
  • Next Change: Difference between versions 16 and 17
  • View Page History

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
  •  Thomas Stuefe Create a temporary shadow branch to push review fixes
    Done: 
    https://github.com/openjdk/lilliput/tree/JEP-450-temporary-fix-branch
    •  Thomas Stuefe Crash in many appcds tests, eg, runtime/cds/appcds/ParallelLoadTest.java +COH CDS metaspace. Reason was a missing mutex lock.
    •  Thomas Stuefe Crash in runtime/cds/appcds/TestParallelGCWithCDS. Reason possibly a merge conflict with the recent array slicing changes in Parallel
  •  Tests broken when UCOH is on by default
    •  Stefan Karlsson Fix TestAutoCreateSharedArchiveNoDefaultArchive 
    •  Thomas Stuefe tools/jlink/plugins/CDSPluginTest.java complains about classes.jsa is not found (only the _coh.jsa files are present)
    •  Thomas Stuefe compiler/c2/irTests/TestPadding.java
    •  

      Thomas Stuefe runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#custom-cl-zgc-generational  - Broken when -Xshare:off is passed in as a test option


Address PR review comments

  •  Thomas Stuefe TinyCP: find a better way to deal with zero 
  •  Thomas Stuefe tiny_classpointer_mode() - find a better name. Potentially, wire it directly to +COH instead of an own flag. https://github.com/openjdk/jdk/pull/20677/files/70f492d381efad303a4941b2ca4403a4ad277fbb#r1750515923
  •  Thomas Stuefe remove mentioning of "legacy" https://github.com/openjdk/jdk/pull/20677/files/70f492d381efad303a4941b2ca4403a4ad277fbb#r1750524690
  •  Thomas Stuefe Improve comment in  CompressedKlassPointers::check_valid_klass https://github.com/openjdk/jdk/pull/20677/files/70f492d381efad303a4941b2ca4403a4ad277fbb#r1750662637


Overview
Content Tools
ThemeBuilder

Terms of Use
• License: GPLv2
• Privacy • Trademarks • Contact Us

Powered by a free Atlassian Confluence Open Source Project License granted to https://www.atlassian.com/software/views/opensource-community-additional-license-offer. Evaluate Confluence today.

  • Kolekti ThemeBuilder Powered by Atlassian Confluence 8.5.21
  • Kolekti ThemeBuilder printed.by.atlassian.confluence
  • Report a bug
  • Atlassian News
Atlassian
Kolekti ThemeBuilder EngineAtlassian Confluence
{"serverDuration": 171, "requestCorrelationId": "1fdd022638e555da"}