Page History

...

The code review policy for OpenFX is this:

• Every change must be reviewed by at least one reviewer before it is pushed to the repo; complicated changes should have a second reviewer
• Each code area has an owner and at least one reviewer
• The owner has final say in what goes in to his area (subject to project leader override in rare cases)
• The reviewer is the primary go-to developer whenever the owner needs a review
• The owner should review all change sets which go into the code area, but can do so after the commit as long as a reviewer has approved it before it is committed
• For complicated or risky reviews, the reviewers should wait a reasonable amount of time before approving to give other interested parties who might be in other time zones a chance to spot problems

...