• Home
    • View
    • Login
    This page
    • Normal
    • Export PDF
    • Page Information

    Loading...
  1. Dashboard
  2. Undefined Space
  3. OpenJFX
  4. Code Reviews

Page History

Versions Compared

Old Version 17

changes.mady.by.user Kevin Rushforth

Saved on Aug 25, 2016

compared with

New Version 18

changes.mady.by.user Kevin Rushforth

Saved on Aug 25, 2016

  • Previous Change: Difference between versions 16 and 17
  • Next Change: Difference between versions 18 and 19
  • View Page History

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

The code review policy for OpenFX is this:

  • Every change must be reviewed by at least one reviewer before it is pushed to the repo; complicated changes should have a second reviewer
  • Each code area has an owner and at least one reviewer
  • The owner has final say in what goes in to his area (subject to project leader override in rare cases)
  • The reviewer is the primary go-to developer whenever the owner needs a review
  • The owner should review all change sets which go into the code area, but can do so after the commit as long as a reviewer has approved it before it is committed
  • For complicated or risky reviews, the reviewers should wait a reasonable amount of time before approving to give other interested parties who might be in other time zones a chance to spot problems

...

Overview
Content Tools
ThemeBuilder

Terms of Use
• License: GPLv2
• Privacy • Trademarks • Contact Us

Powered by a free Atlassian Confluence Open Source Project License granted to https://www.atlassian.com/software/views/opensource-community-additional-license-offer. Evaluate Confluence today.

  • Kolekti ThemeBuilder Powered by Atlassian Confluence 8.5.23
  • Kolekti ThemeBuilder printed.by.atlassian.confluence
  • Report a bug
  • Atlassian News
Atlassian
Kolekti ThemeBuilder EngineAtlassian Confluence
{"serverDuration": 519, "requestCorrelationId": "5734c755136de67c"}