...

All discussion and approvals will happen in JIRA (not on the mailing list). In this manner all activity associated with the closing of the bug is captured in a single place. When the developer has addressed the points raised by the review, a new webrev is created and the review continues.

Testing the Code Prior to Pushing

Developers are expected to test their code prior to pushing it to avoid breaking the build or otherwise impacting other developers with badly broken code. At a minimum, developers must run the unit tests for their area, and verify that Ensemble8 runs. If you are making interface changes or other potentially broad changes, you need to run a "clean" build. For example:

    gradle clean sdk apps test

Closed developers can run the "dev-build-lite.sh" script in the parent jfx directory for additional testing of closed bits.

Committing the Code

All commits will use the following template:

<bugid>: <synopsis-of-symptom>
Summary: <summary-of-code-change> (optional)
Reviewed-by: <reviewer>+ (should be OpenJFX id)
Contributed-by: <contributor-email> (if applicable)

All commits require an associated JIRA except in obvious cases where creating a JIRA to track the unit of work does not make sense. For example, if the initial commit did not include a file, no JIRA is necessary to commit the missing file. Comment changes and changes to most example code do not require a JIRA.  We use common sense to minimize the burden of releasing code for the programer as much as possible, but we must also balance this with a need to track all changes in JIRA.

Resolving the JIRA

Resolve the JIRA using the following template:

...