- Loading...
...
All discussion and approvals will happen in JIRA (not on the mailing list). In this manner all activity associated with the closing of the bug is captured in a single place. When the developer has addressed the points raised by the review, a new webrev is created and the review continues.
Developers are expected to test their code prior to pushing it to avoid breaking the build or otherwise impacting other developers with badly broken code. At a minimum, developers must run the unit tests for their area, and verify that Ensemble8 runs. If you are making interface changes or other potentially broad changes, you need to run a "clean" build. For example:
XXXX
All commits will use the following template:
...