Page History

...

The team has been evaluating Crucible as a code review tool. Unfortunately, Crucible is not integrated with JIRA and cannot be accessed by the community. Therefore, we have decided to revert to webrev and conduct code reviews in JIRA bugs.

Starting a Review

When code is ready for review, the developer creates a webrev and makes it available at a public link location (seesee http://openjdk.java.net/guide/codeReview.html).

Then they do the following:

• Add the list of reviewers to the watchers list in JIRA
• Add a comment to the JIRA with an indication that the review is starting, a link to the webrev, a list of desired reviewers, and any technical information that would assist reviewers. The  The following is a good example for the JIRA comment to start the review:
  . 
  Please review the following webrev: http://cr.openjdk.java.net/foo/bar
  Reviewers: kcr, snorthov
  This is a really complicated, yet elegant fix to this issue. The idea is to do this, that, and the other thing, thus avoiding the xyz bug...

...